Fix: adjust button layout to prevent overlap in ZapPlanner#2023
Open
kanishka0411 wants to merge 2 commits intogetAlby:masterfrom
Open
Fix: adjust button layout to prevent overlap in ZapPlanner#2023kanishka0411 wants to merge 2 commits intogetAlby:masterfrom
kanishka0411 wants to merge 2 commits intogetAlby:masterfrom
Conversation
Contributor
📝 WalkthroughWalkthroughThe ZapPlanner dialog trigger Button gains accessibility and responsive tweaks: an Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@frontend/src/screens/internal-apps/ZapPlanner.tsx`:
- Around line 358-362: The icon-only Button with PlusCircleIcon and className
"max-lg:size-9" lacks an accessible name on small screens; add an accessible
label by adding aria-label="New Recurring Payment" to the Button element (or
alternatively include a screen-reader-only span such as <span
className="sr-only">New Recurring Payment</span>) while keeping the visible
<span className="hidden lg:inline"> for large screens so the button remains
accessible to assistive tech.
Contributor
|
@kanishka0411 thanks for the PR. Could you add "Fixes # (issue number)" in the description? |
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1816
Makes the "New Recurring Payment" button responsive by showing only the icon on smaller screens to prevent layout overlap.
Summary by CodeRabbit
Style
Chores
✏️ Tip: You can customize this high-level summary in your review settings.